Skip to content

chore(docs): Minor updates for NSG, routing profiles, and boot order#3277

Open
bcavnvidia wants to merge 2 commits into
NVIDIA:mainfrom
bcavnvidia:docs
Open

chore(docs): Minor updates for NSG, routing profiles, and boot order#3277
bcavnvidia wants to merge 2 commits into
NVIDIA:mainfrom
bcavnvidia:docs

Conversation

@bcavnvidia

Copy link
Copy Markdown
Contributor

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@copy-pr-bot

copy-pr-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f172174d-12a3-4310-9bf7-6e67bfb0c747

📥 Commits

Reviewing files that changed from the base of the PR and between e6ca959 and e7c795f.

📒 Files selected for processing (1)
  • docs/manuals/networking/network_security_groups.md
✅ Files skipped from review due to trivial changes (1)
  • docs/manuals/networking/network_security_groups.md

Summary by CodeRabbit

  • Documentation
    • Clarified network security group behavior for optional caller-supplied IDs, including how collisions are handled and what to do when a 409 Conflict occurs.
    • Updated VPC routing notes to reflect that default network virtualization settings vary by site setup and interface, and to recommend explicitly specifying FNN for production.
    • Expanded troubleshooting for boot interface/device changes after DPU replacement, including Dell/VPI scenarios and recommended checks and next steps.

Walkthrough

This PR updates documentation for NSG id handling, VPC network virtualization defaults, and DPU boot-interface troubleshooting after replacement.

Changes

Documentation Updates

Layer / File(s) Summary
NSG id collision documentation
docs/manuals/networking/network_security_groups.md
Clarifies optional caller-supplied NSG id behavior, returned id values, and 409 Conflict handling when an id collides.
VPC virtualization default clarification
docs/manuals/vpc/vpc_routing_profiles.md
Replaces the single default virtualization claim with site- and interface-dependent behavior and recommends explicit FNN for production.
DPU boot-interface troubleshooting entry
docs/provisioning/boot-interfaces-and-dpu-modes.md
Adds a troubleshooting row for boot-interface loss after DPU replacement, including normalization checks and re-ingest fallback.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • NVIDIA/infra-controller#2797: Both changes extend troubleshooting and boot-interface guidance in docs/provisioning/boot-interfaces-and-dpu-modes.md.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the documentation updates across NSG, routing profiles, and boot order.
Description check ✅ Passed The description is related to the changeset and correctly classifies it as an internal docs update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bcavnvidia bcavnvidia marked this pull request as ready for review July 8, 2026 20:29
@bcavnvidia bcavnvidia requested a review from polarweasel as a code owner July 8, 2026 20:29
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

🔍 Container Scan Summary

No Grype artifacts were found to aggregate.

@bcavnvidia bcavnvidia enabled auto-merge (squash) July 8, 2026 21:27

@polarweasel polarweasel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, then GTG!

Comment thread docs/manuals/networking/network_security_groups.md Outdated
Co-authored-by: Alex Ball <awball@polarweasel.org>
Signed-off-by: Brian C. <bcavanagh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants