Skip to content

helm: add nodeSelector to upgrade-crd hook Job to prevent Windows scheduling #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iacker wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −0
Open

helm: add nodeSelector to upgrade-crd hook Job to prevent Windows scheduling #2640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6947b3c
helm: add nodeSelector to upgrade-crd hook Job to prevent Windows sch…
iacker Jul 14, 2026
e9d6cc3
helm: also add nodeSelector to cleanup-crd hook Job
iacker Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions deployments/gpu-operator/templates/cleanup_crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.operator.nodeSelector }}
nodeSelector:
{{- toYaml .Values.operator.nodeSelector | nindent 8 }}
{{- else }}
nodeSelector:
kubernetes.io/os: linux
{{- end }}
containers:
- name: cleanup-crd
image: {{ include "gpu-operator.fullimage" . }}
Expand Down
6 changes: 6 additions & 0 deletions deployments/gpu-operator/templates/upgrade_crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
nodeSelector:
{{- if .Values.operator.nodeSelector }}
{{- toYaml .Values.operator.nodeSelector | nindent 8 }}
{{- else }}

@tariq1890 tariq1890 Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of the else block, can we add just a default value for this parameter in values.yaml ?

@tariq1890 tariq1890 Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iacker Please address this comment as well

kubernetes.io/os: linux
{{- end }}
containers:
- name: upgrade-crd
image: {{ include "gpu-operator.fullimage" . }}
Expand Down