fix(nvidia-mig-manager): select package matching target architecture - #1399
Open
100milliongold wants to merge 1 commit into
Open
fix(nvidia-mig-manager): select package matching target architecture#1399100milliongold wants to merge 1 commit into
100milliongold wants to merge 1 commit into
Conversation
Both download URLs were pinned to x86_64, so on aarch64 the task either got a 404 or installed a package dpkg/rpm rejects for the wrong architecture, and MIG configuration never came up on ARM nodes. Build the URLs from ansible_architecture. The two asset families spell the architecture differently -- the .deb uses Debian names (amd64/arm64) and the .rpm uses kernel names (x86_64/aarch64) -- so they need separate maps. arm64 is accepted as an input value to match roles/nvidia-dgx/vars/ubuntu-24.04.yml, which already tests for both spellings. An unlisted architecture is passed through unchanged and yields a URL for an asset that does not exist; v0.14.2 publishes only x86_64 and aarch64. The download then fails with a clear 404 rather than installing a package built for another architecture. The version and release number move into their own variables because the two URLs repeated the version four times between them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roles/nvidia-mig-manager/defaults/main.ymlpins both package URLs to x86_64:On aarch64 the download either 404s or installs a package
dpkg/rpmrejectsfor the wrong architecture, so MIG configuration never comes up on ARM nodes
(GH200, Grace-Hopper).
Change
Build both URLs from
ansible_architecture.The two asset families spell the architecture differently, so they need separate
maps — the
.debuses Debian names and the.rpmuses kernel names:amd64x86_64arm64aarch64arm64is accepted as an input value to match existing repository practice:roles/nvidia-dgx/vars/ubuntu-24.04.yml:2already testsansible_architecture in ['aarch64', 'arm64'].An unlisted architecture is passed through unchanged, which yields a URL for an
asset that does not exist — v0.14.2 publishes only x86_64 and aarch64 (
.deb,.rpm,.tar.gzfor each). The download then fails with a clear 404 instead ofinstalling a package built for the wrong architecture, and MIG-capable hardware
is limited to those two architectures in any case.
The version and release number are also lifted into their own variables. This is
outside the architecture change, and the reason is duplication: the two URLs
repeat the version four times between them, so a bump previously meant editing
four places in two lines. x86_64 resolves to the same two URLs as before.
Verification
Asset names read from the release itself:
All four rendered URLs return HTTP 206 to a ranged request (the redirect target
serves partial content):