skills(multi-objective): add blank line after frontmatter to enable skill signing#1433
Conversation
…kill signing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR updates skill documentation and the skill-card and benchmark reports (content, evaluation metadata, and result tables), and replaces the skill.oms.sig DSSE signature bundle; it also inserts one blank line in SKILL.md. ChangesCuOpt Multi-Objective Skill updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-multi-objective-exploration/skill-card.md`:
- Around line 32-34: The "Evaluation Agents Used" entries use only code names
(`claude-code`, `codex`) instead of the required human-readable format; update
the list under the "Evaluation Agents Used" heading to follow the template
pattern by prepending human-readable names and keeping the code names in
parentheses (e.g., "Claude Code (`claude-code`)", "Codex (`codex`)") so the
entries for claude-code and codex match the common skill-card contract and
NVSkills validation expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2aed5447-c04b-4101-844f-fba360d4a108
📒 Files selected for processing (3)
skills/cuopt-multi-objective-exploration/BENCHMARK.mdskills/cuopt-multi-objective-exploration/skill-card.mdskills/cuopt-multi-objective-exploration/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
- skills/cuopt-multi-objective-exploration/BENCHMARK.md
| ## Evaluation Agents Used: <br> | ||
| - Claude Code (`claude-code`) <br> | ||
| - Codex (`codex`) <br> | ||
| - claude-code <br> | ||
| - codex <br> |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Evaluation Agents format deviates from the documented template pattern.
Lines 32-34 list agent names as code-only (claude-code, codex), but the common skill-card template (referenced in context) specifies the format as Human-Readable Name (code-name), e.g., - Claude Code (claude-code). The current version is missing the human-readable agent names.
Verify whether this format change is intentional or should be corrected to match the template contract for consistency with other skills and NVSkills validation expectations.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-multi-objective-exploration/skill-card.md` around lines 32 - 34,
The "Evaluation Agents Used" entries use only code names (`claude-code`,
`codex`) instead of the required human-readable format; update the list under
the "Evaluation Agents Used" heading to follow the template pattern by
prepending human-readable names and keeping the code names in parentheses (e.g.,
"Claude Code (`claude-code`)", "Codex (`codex`)") so the entries for claude-code
and codex match the common skill-card contract and NVSkills validation
expectations.
|
/ok to test 69be7d8 |
Summary
---inskills/cuopt-multi-objective-exploration/SKILL.mdto enable skill signing.Test plan
🤖 Generated with Claude Code