Use tags for blob links from a release by mdboom · Pull Request #3165 · NVIDIA/cuda-python

mdboom · 2026-10-20T20:19:39Z

Fixes #3164.

This will help us so we can rename directories and files in the future without breaking published links.

coderabbitai · 2026-10-20T20:25:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4f2769cc-3a5a-4db8-8510-02b443c91966

📥 Commits

Reviewing files that changed from the base of the PR and between 1f085a6 and 1e23b52.

📒 Files selected for processing: 12

.github/workflows/ci-pixi-source-test.yml
.github/workflows/ci.yml
cuda_bindings_13/AGENTS.md
cuda_bindings_13/_build_shared.py
cuda_bindings_13/setup.py
cuda_core/AGENTS.md
cuda_core/docs/source/conf.py
cuda_core/pyproject.toml
cuda_core/setup.py
cuda_core/tests/AGENTS.md
cuda_pathfinder/_build_shared.py
cuda_python_test_helpers/cuda_python_test_helpers/graphics.py

🚧 Files skipped from review as they are similar to previous changes: 1

cuda_core/pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Summary

Summary by CodeRabbit

Packaging
- Improved package metadata generation for versioned releases.
- Ensured source links point to the appropriate release tag while development and local builds continue using the main branch.
- Included required build helpers and licensing information in distributed packages.
Documentation
- Added repository navigation links and updated package references across documentation.
- Clarified supported source-build coverage and shared build requirements.
Maintenance
- Updated CI dependency references and graphics-test documentation to reflect current package naming.

Changes

The shared build helper now rewrites GitHub main links to release tags during package metadata generation. Package setup scripts register this behavior, and repository documentation and references use updated package and repository links.

Release-tagged package links

Layer / File(s)	Summary
Release-aware `egg_info` helper `cuda_bindings_13/_build_shared.py`, `cuda_bindings_13/AGENTS.md`	Adds `make_egg_info_command`, which rewrites GitHub source links for release builds.
Package setup wiring `cuda_bindings_13/setup.py`, `cuda_core/setup.py`, `cuda_pathfinder/setup.py`, `cuda_pathfinder/MANIFEST.in`, `cuda_pathfinder/_build_shared.py`	Registers the custom command for package builds and packages the shared helper for `cuda_pathfinder`.
Repository links and references `cuda_core/docs/source/`, `cuda_core/pyproject.toml`, `.github/workflows/`, `cuda_python_test_helpers/*`, `cuda_core/AGENTS.md`, `cuda_core/tests/AGENTS.md`	Adds the `repo-tree` role, updates repository metadata, and renames package references to `cuda-bindings`.

Assessment against linked issues

Objective	Addressed	Explanation
Generate PyPI package links that use the exact release tag instead of `main` [`#3164`]	✅

Suggested reviewers: rwgk, juenglin

Priority: ➖ Normal

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: 🔵 Low · up to 1e23b

Pathfinder builds require symlink support or the documented checkout configuration; release-link rewriting has no established current-head failure.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c752a927-e0b0-439a-bf22-635c3f038f9e

📥 Commits

Reviewing files that changed from the base of the PR and between b288fc8 and 1f085a6.

📒 Files selected for processing: 10

cuda_bindings/AGENTS.md
cuda_bindings/_build_shared.py
cuda_bindings/setup.py
cuda_core/docs/source/10_minutes_to_cuda_core.rst
cuda_core/docs/source/conf.py
cuda_core/pyproject.toml
cuda_core/setup.py
cuda_pathfinder/MANIFEST.in
cuda_pathfinder/_build_shared.py
cuda_pathfinder/setup.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

github-actions · 2026-10-20T20:39:29Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

rwgk

LGTM!

The agent I used to review this PR already figured out what to do once #3147 merges (currently its CI is still waiting for runners). I'll update this PR as soon as #3147 lands.

copy-pr-bot · 2026-10-20T23:47:04Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>

rwgk · 2026-10-20T23:59:47Z

codex GPT-6.1-Sol ultra on behalf of Ralf:

Now that #3147 has merged, this PR includes two follow-up commits:

e4965962072 merges current main, resolves the documentation conflicts, and retargets the new Pathfinder helper symlink to cuda_bindings_13/_build_shared.py.
1e23b520184 addresses @juenglin's wording suggestions on #3147. This changes 11 lines across six files, entirely comments, docstrings, and documentation prose. Package references are version-neutral again; actual source-directory paths keep the _13 suffix.

Ralf deferred the prose corrections so the rename could land using its nearly completed CI run. Including that small follow-up in this already-needed integration update lets one planned full CI run cover both changes, conserving runner capacity. The prose corrections remain in their own commit for easy review.

Full local pre-commit and focused packaging checks passed, including a Pathfinder wheel rebuilt from its sdist. The PR remains draft; full CI has not been triggered for these updates.

rwgk · 2026-10-21T00:03:39Z

/ok to test 1e23b52

Removed preview folders for the following PRs: - PR #3116 - PR #3118 - PR #3130 - PR #3143 - PR #3147 - PR #3151 - PR #3165

Use tags for blob links from a release

1f085a6

mdboom requested a review from rwgk October 20, 2026 20:19

mdboom self-assigned this Oct 20, 2026

github-actions Bot added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module labels Oct 20, 2026

mdboom added the documentation Improvements or additions to documentation label Oct 20, 2026

mdboom added this to the cuda.core next milestone Oct 20, 2026

coderabbitai Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread cuda_pathfinder/_build_shared.py Outdated

rwgk reviewed Oct 20, 2026

View reviewed changes

rwgk marked this pull request as draft October 20, 2026 23:47

rwgk added 2 commits October 20, 2026 16:53

Merge main and adapt release links to cuda_bindings_13

e496596

Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>

Clarify version-neutral package names after source-root rename

1e23b52

Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>

github-actions Bot added the CI/CD CI/CD infrastructure label Oct 20, 2026

rwgk approved these changes Oct 21, 2026

View reviewed changes

rwgk marked this pull request as ready for review October 21, 2026 00:18

rwgk enabled auto-merge (squash) October 21, 2026 00:18

rwgk merged commit efd58e4 into NVIDIA:main Oct 21, 2026
220 of 223 checks passed

rwgk mentioned this pull request Oct 21, 2026

cuda.bindings: rename CUDA 13 source root to cuda_bindings_13 #3147

Merged

2 tasks done

github-actions Bot pushed a commit that referenced this pull request Oct 21, 2026

Clean up PR preview folders for 7 closed/merged PRs

920d7b6

Removed preview folders for the following PRs: - PR #3116 - PR #3118 - PR #3130 - PR #3143 - PR #3147 - PR #3151 - PR #3165

rwgk mentioned this pull request Oct 21, 2026

cuda.bindings: integrate CUDA 12 source with shared build tooling #3173

Open

2 tasks done

Navigation Menu

Repository navigation

Use tags for blob links from a release - #3165

Use tags for blob links from a release#3165
rwgk merged 3 commits into
NVIDIA:mainfrom
mdboom:use-tag-for-blob-link

mdboom commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

Summary by CodeRabbit

Changes

Assessment against linked issues

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

rwgk left a comment

Uh oh!

copy-pr-bot Bot commented Oct 20, 2026

Uh oh!

rwgk commented Oct 20, 2026

Uh oh!

rwgk commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mdboom commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Changes

Assessment against linked issues

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rwgk left a comment

Choose a reason for hiding this comment

Uh oh!

copy-pr-bot Bot commented Oct 20, 2026

Uh oh!

rwgk commented Oct 20, 2026

Uh oh!

rwgk commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading