Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/cuPhoton/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
b4b97c7 to
777538f
Compare
3d51f5f to
b0946d0
Compare
777538f to
f0a16d3
Compare
melo-gonzo
left a comment
There was a problem hiding this comment.
Two regressions need fixes: FITS ingestion in the separate-stage benchmark and named-HDU compatibility in raw-data builders. Reproductions and suggested fixes are inline.
b0946d0 to
e3356be
Compare
f0a16d3 to
dcfc778
Compare
e3356be to
941c8c2
Compare
Signed-off-by: Trent Nelson <trentn@nvidia.com>
Signed-off-by: Trent Nelson <trentn@nvidia.com>
Signed-off-by: Trent Nelson <trentn@nvidia.com>
dcfc778 to
e91bbb6
Compare
The device pipeline requires prepared NPY inputs. This adds FITS descriptors so workers can decode supported images with xDR and pass device arrays into the existing subtraction, fitting, and classification stages. Shared HDUs are read once, input reading is timed separately, and artifacts record the actual reader. The shared reader and xFit prerequisites are on main; this PR has no pending PR dependency.
xScan also gains
predict_fitsfor explicit candidate stamps from aligned FITS planes. Raw dataset builders preserve named-HDU selection for full images and bounded cutouts. The separate-stage benchmark reads all FITS roles, including variance and masks when the science images are NPY. Inputs must already provide the required alignment and mask semantics.--fits-reader auto|astropy|xdris available ondata-build-autoscan-raw,data-build-nodiff-raw,data-build-lsstcomcam-smoke,run-pipeline, andbenchmark-pipeline. Omitting it preserves manifest selections; an explicit choice overrides every FITS descriptor before constructing work identities and reaches benchmark subprocesses and stage reads. NPY inputs and source manifests are unchanged. Selecting Astropy still requires the pipeline's downstream GPU runtime; xDR can use ordinary I/O withKVIKIO_COMPAT_MODE=ONwhen native GDS is unavailable.The independent change passed 326 CLI, FITS, benchmark, executor, and Dragon tests, with four GPU-dependent skips. All lint hooks passed, including type checking. Earlier composed-series validation passed 2,755 CPU tests with 188 skips. Local GPU staged xPois checks with all-FITS and mixed inputs matched NPY outputs exactly under Astropy and automatic selection; auto fell back to Astropy, and native xDR was unavailable in that source environment. The subsequent rebase onto the GPU-check workflow changes ancestry only.
Earlier implementation measurements used registered Rubin inputs and fixed candidates:
These results used three warm measured rounds; the distributed checks included one warmup. Retained numerical outputs matched, including 704 distributed decoded-array comparisons. FITS inputs were lossless encodings of already registered arrays. Input conversion and cold startup are excluded; distributed batch timers also exclude readiness and coordinator auditing. A separate native-GDS run recorded cuFile P2P payload reads without POSIX fallback or errors. These GPU, GDS, and distributed measurements predate the current fixes and were not repeated for this rebase.