Skip to content

Remove device side validation of QB bounds - #3734

Open
ksivaman wants to merge 2 commits into
NVIDIA:mainfrom
ksivaman:remove_qb_bounds_device_side_validation
Open

ksivaman wants to merge 2 commits into
NVIDIA:mainfrom
ksivaman:remove_qb_bounds_device_side_validation

Conversation

@ksivaman

Copy link
Copy Markdown
Member

Description

Remove device side input tensor validation. This is also a blocker for the torch.compile effort from @pggPL for the fused router.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring
  • Performance

Changes

  • Don't validate QB bounds.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
ksivaman requested review from pggPL and tdophung October 23, 2026 18:22
@ksivaman ksivaman added the 2.21 label Oct 23, 2026
@ksivaman
ksivaman requested a review from ptrendx as a code owner October 23, 2026 18:22
@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the change since the previous review only reformats a call.

Summary

Removes QB bounds-value checks and their host synchronization. Histogram writes still clamp bin indices. Older validation helpers remain as deprecated aliases or no-ops.

  • QB routing skips bounds checks and keeps histogram writes within range.

Reviews (2) · Last reviewed commit: "[pre-commit.ci] auto fixes from pre-comm..." · Reviewed by Greptile

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant