Skip to content

[Common] CGEMM stream ID logging - #3727

Open
jberchtold-nvidia wants to merge 6 commits into
NVIDIA:mainfrom
jberchtold-nvidia:jberchtold/cgemm-stream-id-logging
Open

jberchtold-nvidia wants to merge 6 commits into
NVIDIA:mainfrom
jberchtold-nvidia:jberchtold/cgemm-stream-id-logging

Conversation

@jberchtold-nvidia

Copy link
Copy Markdown
Collaborator

Description

Default is no logging. If the user sets NVTE_LOG_COLLECTIVE_GEMM_STREAM_IDS=1, then stream IDs will be logged

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Log stream IDs behind env var

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
@jberchtold-nvidia
jberchtold-nvidia force-pushed the jberchtold/cgemm-stream-id-logging branch from f17b8d7 to 4383a83 Compare October 22, 2026 16:27
@jberchtold-nvidia

Copy link
Copy Markdown
Collaborator Author

/te-ci arm64 L1

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change affects logging during collective GEMM context creation.

Add the missing cuBLASMp skip before merging so optional builds do not fail the distributed tests.

Findings

  1. P1 Builds without cuBLASMp fail ▶

Summary

Adds opt-in logging of collective GEMM stream IDs and ranks.

  • Collective GEMM contexts can print their CUDA stream IDs by rank.

Reviews (4) · Last reviewed commit: "Merge branch 'main' into jberchtold/cgem..." · Reviewed by Greptile

Comment thread tests/cpp_distributed/test_comm_gemm.cu Outdated
@fheinecke

Copy link
Copy Markdown
Collaborator

/te-ci arm64 L1

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
@jberchtold-nvidia

Copy link
Copy Markdown
Collaborator Author

/te-ci L1 arm64

Comment on lines +43 to +48
TEST(CommGemmStreamLogging, LogsStreamIdToStdout) {
int nranks{};
int rank{};
CHECK_MPI(MPI_Comm_size(MPI_COMM_WORLD, &nranks));
CHECK_MPI(MPI_Comm_rank(MPI_COMM_WORLD, &rank));
ASSERT_EQ(cudaSetDevice(rank), cudaSuccess);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Builds without cuBLASMp fail

The new test calls nvte_comm_gemm_ctx_create without checking nvte_built_with_cublasmp(). With NVTE_WITH_CUBLASMP disabled—the default—the call throws instead of skipping. The QA script launches this test whenever four GPUs are available, so builds without cuBLASMp now fail this suite.

Add the same early skip used by test_comm_gemm.cu, before creating the NCCL communicator.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants