Repository navigation
Support GroupedTensor autograd views and stream tracking - #3701
Merged
vthumbe1503 merged 2 commits intoOct 23, 2026
Merged
Conversation
Contributor
 [Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryAdds grouped-storage views for autograd identity outputs and forwards CUDA stream tracking to backing buffers.
Reviews (6) · Last reviewed commit: "Merge branch 'main' into grouped-tensor-..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
phu0ngng
self-requested a review
October 20, 2026 22:08
Member
|
@vthumbe1503 Please sign every commit in this PR. See https://github.com/NVIDIA/TransformerEngine/blob/main/CONTRIBUTING.rst#sign-your-work |
Preserve autograd view metadata for GroupedTensor wrappers and record streams on their backing tensors. Add focused coverage for gradient propagation through an identity view and for stream tracking. Signed-off-by: Varun Thumbe <vthumbe@nvidia.com>
vthumbe1503
force-pushed
the
grouped-tensor-record-stream-view
branch
from
October 23, 2026 16:28
53e37e8 to
f057413
Compare
Collaborator
Author
|
/te-ci pytorch |
ksivaman
reviewed
Oct 23, 2026
Comment on lines
263
to
264
| # DDP and mcore use expand_as(self) to build a dummy autograd node and | ||
| # access gradient accumulators during parameter hook registration. |
Member
There was a problem hiding this comment.
This comment is not accurate anymore because we have an expand_as in GroupedTensor's expand_as.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: