Repository navigation
[Common] Optimized kernels for swizzling and remove obsolete narrow scaled kernels - #3682
Open
vthumbe1503 wants to merge 1 commit into
Open
vthumbe1503 wants to merge 1 commit into
vthumbe1503 wants to merge 1 commit into
Conversation
vthumbe1503
marked this pull request as ready for review
October 14, 2026 06:19
Collaborator
Author
|
/te-ci |
Contributor
[Medium impact] The PR appears safe to merge; no outstanding actionable findings remain. SummaryThe PR enables optimized scale-swizzling kernels and removes obsolete narrow-width kernels.
No new actionable issues were found. CUDA tests were not run. Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Check tensors and alignment] --> B{Scale layout}
B -->|Columnwise MXFP8| C[Columnwise chunk kernel]
B -->|Rowwise or NVFP4| D{Width and tile count}
D -->|Fits heuristic| E[Rowwise full-width kernel]
D -->|Otherwise| F[Generic rowwise kernel]
Reviews (6) · Last reviewed commit: "Optimize scale swizzle kernels" · Reviewed by Greptile |
Member
|
@vthumbe1503 Please sign every commit in this PR. See https://github.com/NVIDIA/TransformerEngine/blob/main/CONTRIBUTING.rst#sign-your-work |
vthumbe1503
force-pushed
the
swizzle-per-tile-default
branch
from
October 16, 2026 21:50
12213fd to
540f974
Compare
Collaborator
Author
|
/te-ci L0 |
vthumbe1503
force-pushed
the
swizzle-per-tile-default
branch
from
October 23, 2026 16:19
e5fe40f to
d586c99
Compare
Use per-tile swizzle kernels for small MXFP8 scale tensors and multi-tensor cases. Require 16-byte alignment for every present input and output scale buffer, including buffers unused by a mixed batch. Signed-off-by: Varun Thumbe <vthumbe@nvidia.com>
vthumbe1503
force-pushed
the
swizzle-per-tile-default
branch
from
October 23, 2026 17:28
0391c75 to
a7fd8fb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduced rowwise/colwise swizzling kernels targeted at narrow scale width use-cases. The scope of this PR is to
Blackwell Perf results
MXFP8 rowwise
MXFP8 columnwise
MXFP8 multi-tensor rowwise
MXFP8 multi-tensor columnwise
Rubin perf results
MXFP8 rowwise
MXFP8 columnwise
MXFP8 multi-tensor rowwise
MXFP8 multi-tensor columnwise
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: