Conversation
Add an opt-in W8A8 Thinker and FP16 TTS path for 24 GiB-class hardware. Bound recurrent and cache state across transparent context rollovers, preserve prompt conditioning, and harden ALSA playback, diagnostics, tests, and documentation. Signed-off-by: Yifei Fang <277870278+yifeif-nv@users.noreply.github.com>
Add a source-only Windows voice application with reactive visuals, bounded audio transport, and continuous conversation recovery. PowerShell setup downloads dependencies locally and builds the TensorRT-RTX runtime and model; no third-party packages or model weights are distributed with the example. Add relocation checks, source-artifact auditing, and Windows source CI. Build on the compressed VoiceChat runtime in PR NVIDIA#1218. Signed-off-by: yifeif-nv <277870278+yifeif-nv@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Add a buildable Windows voice application that demonstrates Nemotron VoiceChat through TensorRT-RTX, with live transcripts, reactive visuals, and a presentation mode. The existing full-duplex example uses Linux/ALSA. This source example also addresses delayed playback and repeated replies observed during longer interactive conversations.
This draft depends on #1218. Its existing commit remains in the comparison to
main; review the Windows example commit separately from that prerequisite.Exit Criteria
Implementation
examples/windows_voicechat: sandboxed Electron UI, canvas/SVG visuals, bounded NDJSON C++ bridge, settings, local diagnostics, stream mode, and labeled model-free rehearsal.trt_rtx.Change categories
Validation
Commands and Results
cmake --build build-windows-rtx --parallel 8,ctest --test-dir build-windows-rtx --output-on-failure, andcmake --install build-windows-rtx: passed after the public-header changes, with 10/10 CTests including real RTX inference. Installed public header and exported interface target verified.python -m pytest examples/windows_voicechat/native/test_native_startup.py -qwith the staged bridge: 4 passed.python -m pytest -q -p no:cacheprovider tools/tests/test_architecture.py tools/tests/test_family_impact.py tools/tests/test_public_source_hygiene.py tools/tests/test_pr_metadata.py: 82 passed.node --test examples/windows_voicechat/desktop/tests/*.test.js: 23 passed, including fresh-workspace discovery and relocation.python examples/windows_voicechat/audit_source.py --staged: passed for all 40 example source/text files; negative tests in isolated Git repositories rejected force-added binaries, vendored source, oversized files, and encoded media.Setup.ps1 -Plan: passed. An isolatedSetup.ps1 -Stage Pythondownloaded and verified CPython, created a venv, and imported SSL. Spaces/apostrophes in paths, relative launcher relocation,Run.ps1 -ValidateOnly, and App-only rehearsal validation passed.node desktop/tests/electron-audio.integration.cjsandnode desktop/tests/electron-transcript.integration.cjsfrom the example directory: passed using downloaded Electron and separately installed Playwright; real WebAudio/IPC, 20 ms capture, interruption/reset controls, and 1,034 events with 300 retained rows were checked.python -m pytest -q -p no:cacheprovider families/nemotron_voicechat/tests/test_build_policy.py families/nemotron_voicechat/tests/test_quantization.py: 18 passed.ruff check --config ruff.tomlon changed Python source,clang-format --dry-run --Werroron changed C++ source, andgit diff --check: passed.VALIDATION.mdfor scope and reproduction.Hardware, Environment, and Revisions
e803846cfdfbd7dedcbcbb9d23649e5870fbd8ab; its tree is byte-identical to the locally validated source treecb3410412ec14537403a0297af948e02f67ac56e.7458623963a038fa1ae1f1bac28eee6a5c792514.nvidia/NVIDIA-NemotronLabs-VoiceChat-11Brevision359ada7b1c60851e40ff08065f9b0340244f27e0; tokenizer revision6533e8de2c68e4536bf7c411d7a3ce5734111476.Not Run / Remaining Gaps
Contributor Self-Review
Notes For Future Readers
Risk level
The example is opt-in and keeps model logic family-local, but adds Windows native loading/build support and changes experimental VoiceChat conversation recovery. Fresh-machine qualification and prerequisite integration remain necessary before treating it as a turnkey release.