[None][docs] Remove ghost --topr from RocketKV example command - #18576
[None][docs] Remove ghost --topr from RocketKV example command#18576imitater-dou wants to merge 1 commit into
Conversation
examples/llm-api/llm_sparse_attention.py exposes --topk but not --topr; RocketSparseAttentionConfig.topr still defaults to 128 in the API. Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe RocketKV example command removes the ChangesRocketKV command update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This removes an invalid command-line flag from the RocketKV example without changing runtime or API behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the issue, affected files, root cause, exact change, and test plan. It is sufficiently complete for this documentation-only change, although it does not reproduce the full repository checklist. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
The RocketKV example command in
examples/sparse_attention/RocketKV.mddocuments--topr 128, butexamples/llm-api/llm_sparse_attention.pyonly exposes--topk(not--topr). Copy-pasting the documented command fails with an unrecognized-arguments error.RocketSparseAttentionConfig.toprremains a valid LLM API field (default128); the Python API snippet and Configuration Arguments section are unchanged. The example script relies on that API default when constructingRocketSparseAttentionConfig.Repro (on
main@ d7d79c3)Change
--topr 128from the Example Command inRocketKV.md.Test plan
llm_sparse_attention.pyargparsetoprDev Engineer Review
--topr 128flag from the RocketKV example command.--topkoption.QA Engineer Review
No test changes.