[https://nvbugs/6691772][fix] Remove the TLLM_K3_MLA_GEN_BACKEND=trtllm-gen pin from worker_env_var so… - #18575
Conversation
…from the Kimi-K3 DEP16 disagg perf config The config pins TLLM_K3_MLA_GEN_BACKEND=trtllm-gen while both the ctx and gen sides set enable_attention_dp: true. Attention-DP collapses tp_size to 1, so every rank keeps all 96 Kimi-K3 query heads, and trtllm-gen MLA decode rejects 64 < num_heads_q < 128 -- every CTX_0 and GEN_0 rank died before serving. The pin was valid when the config was added: Kimi-K3 padded 96 heads up to 128 back then, so trtllm-gen was legal. Removing that padding exposed 96 raw and silently invalidated the pin. Drop it so the module default applies; cute-dsl is the tuned backend at H=96 on this BF16 KV cache, and no other Kimi config sets this knob. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe worker environment configuration removes the explicit ChangesWorker backend configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This PR removes an explicit backend pin from a benchmark configuration so the module default can be used. No concrete correctness, deployment, or availability risk remains at the current head; it is merge-ready after normal checks. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the root cause, fix, affected configuration, reproduction details, test plan, and bug link. It uses Summary and Test plan headings instead of the template's Description and Test Coverage headings, but the required information is present. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[Repair Bot][Two-Leg Repro Comparison:6691772-f221314f60af-1788316854606643536] Reproduction comparison:
|
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
I checked this against the current Kimi K3 backend-selection contract. This recipe does not request FP8 KV cache (kv_cache_config.dtype remains auto), and the K3 documentation still lists FP8 KV cache as unsupported; for the supported BF16 KV path, K3's generation MLA default is cute-dsl unless TLLM_K3_MLA_GEN_BACKEND explicitly overrides it.
With enable_attention_dp: true, all 96 K3 query heads remain present on each rank, so removing the explicit trtllm-gen pin lets the model select the backend that supports that head count without changing the DEP16 topology or the rest of the worker runtime environment.
I don't see a blocking issue in this config change.
Summary
TLLM_K3_MLA_GEN_BACKEND=trtllm-genwhileenable_attention_dp: truereplicates all 96 Q heads on every rank, and trtllm-gen MLA decode rejects64 < num_heads_q < 128.TLLM_K3_MLA_GEN_BACKEND=trtllm-genpin fromworker_env_varso the module defaultcute-dsl(the tuned H=96 BF16-KV backend) applies, and update the comment block that named the knob.python .repair-bot/repro.pyTest plan
Links
Reproduction comparison
Signature: ValueError: Kimi K3 MLA: the trtllm-gen generation backend cannot run with 96 query heads per rank (trtllm-gen MLA decode rejects 64 < num_heads_q < 128; under attention-DP every rank keeps all heads). trtllm-gen was selected explicitly — by the FP8-KV-cache override or by TLLM_K3_MLA_GEN_BACKEND=trtllm-gen. Use tensor-parallel head sharding (TEP) so each rank has <= 64 heads, or a BF16 KV cache with the default cute-dsl backend.
Dev Engineer Review
TLLM_K3_MLA_GEN_BACKEND=trtllm-genoverride from the Kimi K3 DEP16 disaggregated performance configuration.cute-dslbackend.QA Engineer Review
No test changes.