Skip to content

[None][infra] Avoid false CBTS follow-up for test lists - #18573

Open
crazydemo wants to merge 1 commit into
NVIDIA:mainfrom
crazydemo:fix/coderabbit-waive-cbts-coverage
Open

[None][infra] Avoid false CBTS follow-up for test lists#18573
crazydemo wants to merge 1 commit into
NVIDIA:mainfrom
crazydemo:fix/coderabbit-waive-cbts-coverage

Conversation

@crazydemo

@crazydemo crazydemo commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • review test-list-only changes directly for valid IDs, formatting, duplicates, and bug references
  • clarify that CBTS touchmap evidence applies to residual source-code changes, not Tier 1 test-list rules
  • prevent missing coverage artifacts alone from producing a needs-follow-up verdict

Testing

  • pre-commit run --files .coderabbit.yaml
  • YAML parsing validation
  • git diff --check

Dev Engineer Review

  • Updated .coderabbit.yaml to validate test-list IDs, formatting, duplicates, and bug references directly.
  • Limited CBTS touchmap evidence checks to residual source-code changes.
  • Prevented missing coverage artifacts alone from causing a needs follow-up verdict.
  • Applied consistent rules to the global review summary and tests/** instructions.
  • No public or exported entities changed.
  • Validation passed for YAML parsing, pre-commit checks, and git diff --check.

QA Engineer Review

No test changes.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
@crazydemo
crazydemo requested a review from a team as a code owner September 2, 2026 03:05
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

This pull request changes a CodeRabbit configuration file. Because it comes from a fork or its author is not a repository collaborator, reviews use only the configuration from the target branch. The proposed configuration will take effect after it is merged.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f0c53bb0-088a-4806-af5e-c7a73223d265

📥 Commits

Reviewing files that changed from the base of the PR and between 1ed2928 and fe23dab.

📒 Files selected for processing (1)
  • .coderabbit.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The review configuration updates test-list QA instructions in the global and tests/** scopes. Reviewers must validate modified lists directly and return only “sufficient” or “insufficient” verdicts.

Changes

Test-list review rules

Layer / File(s) Summary
Direct test-list validation
.coderabbit.yaml
Global and tests/** instructions require validation of modified list files and entries, including IDs, formatting, duplicates, and bug references. CBTS coverage evidence is excluded, and coverage-based follow-up verdicts are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fe23d

This localized configuration change refines how test-list updates are reviewed and does not introduce a product or runtime behavior change; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: dpitman-nvda

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format and clearly describes the infrastructure change that prevents false CBTS follow-up for test-list-only changes.
Description check ✅ Passed The description explains the change and lists relevant validation steps. It uses Summary and Testing headings instead of the template headings and does not include the PR checklist, but it provides th…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change and lists relevant validation steps. It uses Summary and Testing headings instead of the template headings and does not include the PR checklist, but it provides the critical information needed for review.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70883 [ run ] triggered by Bot. Commit: fe23dab Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants