feat(k8s-driver): add default_runtime_class_name config for sandbox pods#1729
Merged
Merged
Conversation
sjenning
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
Collaborator
|
/ok to test 0f18bf7 |
Allow operators to configure a default Kubernetes runtimeClassName that is applied to sandbox pods when the CreateSandbox request does not specify one. This avoids requiring every API caller to explicitly set the runtime class for clusters that always need a specific RuntimeClass (e.g. kata-containers, nvidia). The fallback is applied in the Kubernetes driver only — per-request values still take priority, and an empty default (the built-in) preserves existing behavior (field omitted, cluster default applies).
sjenning
force-pushed
the
feat/default-runtime-class-name
branch
from
0f18bf7 to
730ca3f
Compare
Collaborator
|
/ok to test 730ca3f |
mrunalp
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
default_runtime_class_namefield to the Kubernetes driver config so operators can set a cluster-wide defaultruntimeClassNamefor sandbox pods. When aCreateSandboxrequest does not specify aruntime_class_name, the configured default is applied. Per-request values still take priority.Related roadmap issue #1720
Changes
default_runtime_class_namefield toKubernetesComputeConfig(defaults to empty string, preserving existing behavior)SandboxPodParamsand applied it as a fallback insandbox_template_to_k8s()OPENSHELL_K8S_DEFAULT_RUNTIME_CLASS_NAMEenv var in the standalone driver binaryserver.defaultRuntimeClassNameand conditional TOML renderingdocs/reference/gateway-config.mdxTesting
mise run pre-commitpassesChecklist