chore(k8s): use upstream agent-sandbox manifest in CI/e2e#1657
chore(k8s): use upstream agent-sandbox manifest in CI/e2e#1657rmalani-nv wants to merge 1 commit into
Conversation
TaylorMutch
left a comment
There was a problem hiding this comment.
I would actually like to get away from vendoring the upstream manifests in our repo, since they change quickly and trying to keep up with vendoring is just going to create noise in the repo. Instead we should just use the upstream manifests in our CI / e2e.
Additionally I don't yet see a need for us to pin to a specific version in our public facing docs or in the readme. As we don't yet have a matrix for support (as far as I am aware we aren't seeing any incompatibilities yet, but we can be on the lookout for it; see #1649 for context as well), I'd prefer we not pin in the docs.
9499bc6 to
7f246ec
Compare
|
Pivoted as requested:
|
7f246ec to
676f7e7
Compare
|
Label |
|
/ok to test 676f7e7 |
Drop the vendored deploy/kube/manifests/agent-sandbox.yaml. CI and e2e scripts now apply manifest.yaml directly from github.com/kubernetes-sigs/agent-sandbox releases, pinned via AGENT_SANDBOX_VERSION env (default v0.4.6, overridable) so internal runs stay reproducible. Public docs and the helm chart README continue to reference /releases/latest/download/ — no OpenShell/agent-sandbox support matrix exists yet (see NVIDIA#1649). Adds an air-gap note in docs/kubernetes/setup.mdx enumerating the manifest and image operators need to mirror to an internal registry. Signed-off-by: Roshni Malani <rmalani@nvidia.com>
676f7e7 to
5a613d8
Compare
|
/ok to test 5a613d8 |
|
@TaylorMutch , looks like my okay to test doesn't work, and I needed to update to latest main. I wish test:e2e label let me run tests. |
|
/ok to test 5a613d8 |
Summary
Use the upstream agent-sandbox manifest directly in CI/e2e instead of vendoring a copy of it. Public install docs continue to reference
/releases/latest/download/manifest.yaml.Related Issue
Context: #1649 (no support matrix yet — kept docs/README on
/releases/latest/download/for that reason).Changes
deploy/kube/manifests/agent-sandbox.yaml.e2e/with-kube-gateway.shandtasks/scripts/helm-k3s-local.shnow applymanifest.yamlfromgithub.com/kubernetes-sigs/agent-sandboxreleases, pinned viaAGENT_SANDBOX_VERSIONenv (defaultv0.4.6, overridable).docs/kubernetes/setup.mdx, helm chart README,README.md.gotmpl) with the install step using/releases/latest/download/.docs/kubernetes/setup.mdxenumerating the manifest + image operators need to mirror.The extension CRDs (
SandboxClaim,SandboxTemplate,SandboxWarmPool) are intentionally left out of this PR. When a feature that needs them lands, adding the install line back is a one-liner using the sameAGENT_SANDBOX_VERSIONpin.Testing
mise run pre-commit/mise run cipass locally. Pre-existingpython:typecheckfailures inpython/openshell/sandbox.py(from feat(python-sdk): support OIDC Bearer auth on SandboxClient #1621) are unrelated to this branch.Checklist