Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
kaix-nv
added this pull request to stack #2510
September 22, 2026 21:27
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kaix/linear-attention-qat-m2 #2507 +/- ##
================================================================
- Coverage 70.37% 70.37% -0.01%
================================================================
Files 620 621 +1
Lines 68513 68598 +85
================================================================
+ Hits 48218 48273 +55
- Misses 20295 20325 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kaix-nv
removed this pull request from stack #2510
September 23, 2026 01:07
Signed-off-by: Kai Xu <kaix@nvidia.com>
kaix-nv
force-pushed
the
kaix/linear-attention-qat-m4
branch
from
September 23, 2026 01:16
34e549e to
ff21e39
Compare
kaix-nv
changed the base branch from
kaix/linear-attention-qat-m3
to
kaix/linear-attention-qat-m2
September 23, 2026 01:16
This was referenced Sep 23, 2026
kaix-nv
added this pull request to stack #2521
September 23, 2026 01:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack / merge order: #2497 foundation → #2519 decode + INT8 → #2503 GDN/KDA prefill → #2507 approximate inverse.
All entries remain drafts. #2506 (KDA prefill) and #2509 (original decode) are superseded and closed.
What does this PR do?
Type of change: New feature.
Add an opt-in approximate inverse after the GDN/KDA prefill infrastructure in
#2503. The saved solve policy selects an explicit Neumann polynomial degree and
either Torch or CUDA FP32 execution. Backward differentiates the actual
polynomial; the implementation never silently changes degree or falls back.
Exact triangular solve remains the default.
The current Neumann candidate failed the pinned KDA model-quality screen.
Keep this PR experimental and in draft. The historical study and failed results
are preserved; a successful kernel or optimizer test is not quality recovery.
Usage
Use
{"method": "exact"}(the default) for the supported baseline.See the solve guide.
Testing
7c00dd086d0a882a5bd88337f4796f421ec63426; only commit ancestry changes.and thirteen FLA KDA layer cases, including INT8 and experimental solve
integration. These GPU runs predate the restacked commits and were not rerun
during restacking; the fresh validation above is CPU and pre-commit.
identities, composed operand/state QDQ, save/restore, and packed sequence tails.
Historical model screening used
arcee-ai/AFM-4.5B-Base-KDA-Onlyand a fixedWikiText-2 validation set. Degrees 3, 7, 15, and 31 all failed the declared NLL
margin. Degree 63 is not a numerically safe fallback. Synthetic H100 measurements
also established no speed advantage. The
qualification report
records exact revisions, data, intervals, and limitations. These historical
measurements were not rerun during restacking; no new quality claim is made.
Before your PR is "Ready for review"
Additional Information
Depends on #2503 and comes last in the stack. INT8 model-quality comparisons,
Megatron distributed requalification, and vLLM integration remain pending work
elsewhere in the stack. A better-conditioned inverse approximation needs its own
numerical and model-quality evidence.