Fix GitLab authentication guidance for Enroot - #2493
Draft
chadvoegele wants to merge 1 commit into
Draft
chadvoegele wants to merge 1 commit into
chadvoegele wants to merge 1 commit into
Conversation
Signed-off-by: Chad Voegele <cvoegele@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2493 +/- ##
=======================================
Coverage 71.13% 71.13%
=======================================
Files 602 602
Lines 66403 66403
=======================================
Hits 47239 47239
Misses 19164 19164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepared by Chad's Agent.
What does this PR do?
Type of change: documentation
Fixes the Enroot guidance for authenticated GitLab container-registry imports. The documented flow now:
machineport-free while allowing an explicit reachable port in the URI;The prior token-permission diagnosis was incorrect. A token with
read_registrycompleted GitLab's bearer flow and fetched an ARM64 layer. The failed Enroot command pinned the URI with@sha256:; the proxy permitted the initial manifest-by-digest request, so Enroot 4.1.2 skipped bearer authentication and later requested protected blobs anonymously. A separate:5005attempt failed at the network proxy before registry authentication. A port-qualified credentialmachinealso cannot match Enroot 4.1.x, which strips the port during lookup.Usage
Testing
nemo-evaluator-next:0.5.0.1-harborimage on OCI-JHB with Enroot 4.1.2 using tag-only auth and default parallel downloads; resulting squashfs: 2,469,605,376 bytes.pytest plugins/modelopt/skills/: 106 passed, 1 skipped.Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/AAdditional Information
The PR is intentionally draft pending maintainer review of the GitLab/Enroot guidance.