Skip to content

[Feat] Streaming Dataset, Vllm Dumper#1507

Draft
h-guo18 wants to merge 3 commits into
mainfrom
haoguo/vllm-dumper
Draft

[Feat] Streaming Dataset, Vllm Dumper#1507
h-guo18 wants to merge 3 commits into
mainfrom
haoguo/vllm-dumper

Conversation

@h-guo18
Copy link
Copy Markdown
Contributor

@h-guo18 h-guo18 commented May 16, 2026

What does this PR do?

Type of change: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ✅ / ❌ / N/A
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: ✅ / ❌ / N/A
  • Did you write any new necessary tests?: ✅ / ❌ / N/A
  • Did you update Changelog?: ✅ / ❌ / N/A
  • Did you get Claude approval on this PR?: ✅ / ❌ / N/A

Additional Information

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 16, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 529f7fca-3618-4d74-afc4-fae92822bbb1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch haoguo/vllm-dumper

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

❌ Patch coverage is 3.84615% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.75%. Comparing base (7038dec) to head (864dc89).

Files with missing lines Patch % Lines
.../torch/speculative/plugins/hf_streaming_dataset.py 0.00% 125 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
- Coverage   76.93%   76.75%   -0.19%     
==========================================
  Files         474      475       +1     
  Lines       51506    51635     +129     
==========================================
+ Hits        39625    39630       +5     
- Misses      11881    12005     +124     
Flag Coverage Δ
unit 52.51% <3.84%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@h-guo18 h-guo18 self-assigned this May 18, 2026
h-guo18 added 3 commits May 18, 2026 01:25
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
@h-guo18 h-guo18 force-pushed the haoguo/vllm-dumper branch from 0761d1b to 4252397 Compare May 18, 2026 01:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://NVIDIA.github.io/Model-Optimizer/pr-preview/pr-1507/

Built to branch gh-pages at 2026-05-18 02:05 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@h-guo18 h-guo18 changed the title add vllm dumper [Feat] Streaming Dataset, Vllm Dumper May 18, 2026
@h-guo18 h-guo18 force-pushed the haoguo/vllm-dumper branch from e5c46c7 to 2bc8e4b Compare May 18, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant