Skip to content

fix: DALI warmup slicing can leave empty list before min() - #94

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/dali-fcc60f63
Open

fix: DALI warmup slicing can leave empty list before min()#94
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/dali-fcc60f63

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Problem

fix: DALI warmup slicing can leave empty list before min()

Fix

Replace:

        all_speeds = sorted(all_speeds)[systems:]
        image_type_match[num] = _update_results(image_type_match[num],
                                                all_speeds)

with:

        all_speeds = sorted(all_speeds)
        if len(all_speeds) <= systems:
            print(f'Warning: Not enough DALI speed samples in {log_file}; '
                  'skipping...')
            return {}
        all_speeds = all_speeds[systems:]
        image_type_match[num] = _update_results(image_type_match[num],
                                                all_speeds)

Files changed

  • bobber/lib/analysis/dali.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review July 28, 2026 00:36
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this sweep-generated PR: sole commit is missing a valid Signed-off-by trailer. It does not meet the sweep requirements (single signed-off commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant