fix(rl): restore Python HTTPS support - #1658
Conversation
Signed-off-by: Swarom Muley <smuley@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe RL base image now uses Python 3.13.15 on Debian Bookworm. The Docker build verifies that the copied CPython installation can import ChangesRL base image
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change restores HTTPS support in the RL Python environment and adds an early failure check, with no actionable merge-blocking risk remaining after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Summary
PR #1623 copied CPython 3.13.15 from Debian Trixie into the Ubuntu 24.04 RL base, and the resulting interpreter cannot open HTTPS URLs. That breaks
causal-conv1d's prebuilt-wheel fetch withunknown url type: https, causingnmp-rl-trainingto fail.This keeps Python 3.13.15 but sources it from Bookworm, which uses the same OpenSSL 3.0 generation as the CUDA base, and adds an early
import sslassertion so this incompatibility fails before the expensive RL dependency build.Changes
slim-trixietoslim-bookworm.Human attention needed
nmp-rl-trainingbuild and security scan are CI-only and remain pending.Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
git diff --check— passed.docker buildx imagetools inspect python:3.13.15-slim-bookworm— resolved linux/amd64 and linux/arm64 manifests.docker buildx bake --print nmp-rl-training— passed; the target renders for linux/amd64 and linux/arm64.nmp-rl-trainingbuild, RL smoke test, and security scan — pending CI; the repository explicitly keeps this cold GPU build out of local validation.