feat(sc): support multi-reward GDPO rollouts - #3962
Open
tianyi-zhang-02 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Tianyi Zhang <123608656+tianyi-zhang-02@users.noreply.github.com>
Signed-off-by: Tianyi Zhang <123608656+tianyi-zhang-02@users.noreply.github.com>
tianyi-zhang-02
marked this pull request as ready for review
September 2, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds end-to-end multi-reward support for GDPO in the Single Controller path. Named reward components now survive native async rollout, JSON payload transport, TQ replay, checkpoint restore, and reward penalties, so GDPO can consume
reward/<name>tensors instead of only the summed scalar reward.The rollout boundary validates component schemas and keeps
rewardas the canonical scalar sum. GRPO/PPO behavior is unchanged when components are absent.Issues
Relates to #2625.
Usage
The new functional recipe is:
Validation
main; Python 3.13The functional run reported loss
4.43e-06, grad norm0.00323, generation KL0.000715, and zero masked sequences. It ran from upstreammainat9b25508a3340bffdd8e3a2245ada72279fbc15d6usingnvcr.io/nvidia/nemo-rl:v0.7.0(driver 570.133.20, CUDA 12.8 compatibility runtime, PyTorch cu130).Before your PR is "Ready for review"
Pre checks:
Additional Information
This change is independent of other open contributor branches.