Skip to content

chore: Bump Gym, Megatron-Bridge, vllm for superv3.5 - #3958

Open
yfw wants to merge 9 commits into
super-v3.5-posttrainingfrom
yifu/super35-merge-20260901
Open

chore: Bump Gym, Megatron-Bridge, vllm for superv3.5#3958
yfw wants to merge 9 commits into
super-v3.5-posttrainingfrom
yifu/super35-merge-20260901

Conversation

@yfw

@yfw yfw commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Bump Gym, Megatron-Bridge, vllm and use dedicated super-v3.5-posttraining branches for Gym and Megatron-Bridge.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

yfw and others added 7 commits September 1, 2026 10:44
Point the Megatron Bridge submodule at the tip of chcui/sage/nmvl to test the Sage NMVL integration on the latest super-v3.5-posttraining branch.

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Cherry of 545ba70 (#3905) from main, which this branch's merge base predates.

torch-memory-saver arrives transitively through megatron-core's dev extra as a
git dependency, and its build backend refuses to produce metadata without
TMS_CUDA_MAJOR:

    RuntimeError: TMS_CUDA_MAJOR env var must be set for CUDA builds
                  (use `make build-wheel-multi-cuda` or scripts/build_multi_cuda.sh).

That aborts `uv lock --check` inside the image build (nemo-ci pipeline 65727784
died there), because an env var exported in a CI step does not reach the Docker
build. Declaring it in pyproject.toml makes it travel with the project, so CI,
the Docker build, and local uv runs all get it -- which is exactly why #3905
moved it here and dropped the export from cicd-main.yml.

13 matches docker/Dockerfile's BASE_IMAGE (cuda13.2).

Verified: `uv lock --check` now resolves 551 packages and exits clean on this
branch. The lockfile itself was not stale, so no regeneration is needed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@yfw
yfw requested review from a team as code owners September 2, 2026 01:49
@copy-pr-bot

copy-pr-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: ea67dfd (PR #3958 from yifu/super35-merge-20260901)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of super-v3.5-posttraining branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of super-v3.5-posttraining branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: b10602f (PR #3958 from yifu/super35-merge-20260901)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of super-v3.5-posttraining branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of super-v3.5-posttraining branch (fast-forward)

All submodule changes look good! ✨

@yfw yfw changed the title Bump Gym, Megatron-Bridge, vllm chore: Bump Gym, Megatron-Bridge, vllm for superv3.5 Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: f4dce7c (PR #3958 from yifu/super35-merge-20260901)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of super-v3.5-posttraining branch (fast-forward)
Megatron-Bridge: ✅ PR branch is ahead of super-v3.5-posttraining branch (fast-forward)

All submodule changes look good! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant