Skip to content

perf(docker): hardlink worker venvs into layers - #3947

Open
tdene wants to merge 3 commits into
mainfrom
tde/hardlink_venv_prefetch
Open

perf(docker): hardlink worker venvs into layers#3947
tdene wants to merge 3 commits into
mainfrom
tde/hardlink_venv_prefetch

Conversation

@tdene

@tdene tdene commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Replaces the symlink scheme with hardlinks.
Increased size of image by ~3%.
Reduces number of symlinks from ~1.5M to ~3k.

Improves SQSH conversion time from ~3 hours to ~25 minutes.

See internal pipeline at 65564509.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Replaces the symlink scheme with hardlinks.
Increased size of image by ~3%.
Reduces number of symlinks from ~1.5M to ~3k.

Improves SQSH conversion time from ~3 hours to ~25 minutes.

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene
tdene requested review from a team as code owners September 1, 2026 08:02
@copy-pr-bot

copy-pr-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene
tdene requested a review from a team as a code owner September 2, 2026 06:15
@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Sep 2, 2026
@tdene

tdene commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@terrykong I made a new commit 630d380 that moves the manifest's data from a separate file into pyproject.toml. It's equivalent logic, just with a different home.

If you'd like, take a look at the before-and-after of 630d380

Personally I prefer the before state, with a separate manifest file.

@tdene

tdene commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 630d380

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene
tdene force-pushed the tde/hardlink_venv_prefetch branch from 630d380 to a6e758f Compare September 2, 2026 07:48
@tdene tdene added the CI:L0 Run doctests and unit tests label Sep 2, 2026
@tdene

tdene commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test a6e758f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L0 Run doctests and unit tests Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant