Skip to content

feat(modelopt): add format-general real-quant vLLM rollout - #3945

Draft
mxinO wants to merge 16 commits into
mainfrom
mxin/general-real-quant-refit
Draft

feat(modelopt): add format-general real-quant vLLM rollout#3945
mxinO wants to merge 16 commits into
mainfrom
mxin/general-real-quant-refit

Conversation

@mxinO

@mxinO mxinO commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR extends NeMo-RL native real-quant rollout from a hard-coded NVFP4 path to canonical ModelOpt formats.

  • builds the vLLM deployment configuration from the calibrated policy after policy initialization
  • streams ModelOpt-packed weights and format-defined sidecars from the Megatron-Bridge export plan
  • supports per-layer format selection and mixed schemas without format tables in NeMo-RL
  • removes NeMo-RL NVFP4-specific packing, scale mapping, and low-level vLLM reload logic
  • shares the real-quant orchestration across GRPO and distillation while leaving fake-quant generation unchanged
  • adds a dense W4A16 example and documents the supported boundary

A format is available for rollout when ModelOpt can functionally export its canonical tensors and the pinned vLLM ModelOpt loader accepts that exact schema. Unsupported formats fail during setup rather than silently falling back.

Dependencies

The ModelOpt and Megatron-Bridge pins will be updated after the dependency APIs land.

Validation

  • NeMo-RL focused suite: 678 passed, 6 skipped
  • Megatron quant-worker suite: 24 passed
  • dense W4A16 two-step GRPO smoke completed two refits with finite loss and KL metrics
  • branch linters passed

This remains a draft while dependency pins and exact mixed-format runtime qualification are pending.

mxinO added 14 commits August 15, 2026 09:11
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
…nt-refit

Signed-off-by: Meng Xin <mxin@nvidia.com>

# Conflicts:
#	tests/unit/algorithms/test_grpo.py
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Sep 1, 2026
@mxinO mxinO changed the title refactor(modelopt): generalize real-quant vLLM refit feat(modelopt): add format-general real-quant vLLM rollout Sep 1, 2026
mxinO added 2 commits August 31, 2026 19:49
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant