perf: compute selected token logprobs directly - #3930
Open
CarlosGomes98 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
/ok to test 7cfd947 |
CarlosGomes98
commented
Sep 1, 2026
Signed-off-by: Carlos Gomes <cgomes@nvidia.com>
CarlosGomes98
force-pushed
the
cgomes/optimize-selected-logprobs
branch
from
September 1, 2026 22:17
7cfd947 to
ec226ec
Compare
CarlosGomes98
added
the
CI:Lfast
Contributor
Author
|
/ok to test 7cfd947 |
@CarlosGomes98, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
Contributor
Author
|
/ok to test ec226ec |
svcnvidia-nemo-ci
added
the
waiting-on-customer
Signed-off-by: Carlos Gomes <cgomes@nvidia.com>
Contributor
Author
|
/ok to test 7ed8ac3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Compute the selected logprobs directly instead of subsequently masking. Doesn't materialize the full vocabulary-sized logprob tensor. This reduces memory use and unnecessary computation.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information