Skip to content

Fix pure Fragmentation scale evolution#398

Merged
Radonirinaunimi merged 4 commits intomasterfrom
fix-frg-scale-evolution
Apr 29, 2026
Merged

Fix pure Fragmentation scale evolution#398
Radonirinaunimi merged 4 commits intomasterfrom
fix-frg-scale-evolution

Conversation

@Radonirinaunimi
Copy link
Copy Markdown
Member

Sorry for having been slow lately which has resulted in #394 being blocked. In the meantime, I stumbled upon an issue that has to do with evolving pure FF grids, ie with fac = NoScale and only fragmentation scale involved. This PR provides a fix for this and adds a test.

@Radonirinaunimi Radonirinaunimi added the bug Something isn't working label Apr 15, 2026
@Radonirinaunimi Radonirinaunimi changed the title Fix frg scale evolution Fix pure Fragmentation scale evolution Apr 15, 2026
@Radonirinaunimi Radonirinaunimi requested a review from cschwan April 15, 2026 20:21
Copy link
Copy Markdown
Contributor

@cschwan cschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the TODO comment,

// TODO: implement evolution for non-zero fragmentation scales

signifies that any evolution with fragmentation function hasn't been tested yet. Is that the case and is you testing SIA just the first instance of finding something wrong?

Comment thread pineappl_py/src/evolution.rs
@Radonirinaunimi
Copy link
Copy Markdown
Member Author

I believe the TODO comment,

// TODO: implement evolution for non-zero fragmentation scales

signifies that any evolution with fragmentation function hasn't been tested yet. Is that the case and is you testing SIA just the first instance of finding something wrong?

The comment indeed mentions that we FF scale evolution has not been tested at all. The reason was that until now we did not really grids and evolution operators to really test it. Now that we have PineAPFEL, we can easily test this for not only SIA but also for SIDIS, etc. The issue originally manifested from SIA but noticed it also for SIDIS. And this PR solves both.

@Radonirinaunimi
Copy link
Copy Markdown
Member Author

@cschwan Are you perhaps planning to look into this PR or should I merge it?

@cschwan
Copy link
Copy Markdown
Contributor

cschwan commented Apr 28, 2026

@Radonirinaunimi: merge it!

@Radonirinaunimi Radonirinaunimi merged commit 07777c9 into master Apr 29, 2026
10 checks passed
@Radonirinaunimi Radonirinaunimi deleted the fix-frg-scale-evolution branch April 29, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants