Skip to content

Added optional permissions_boundary to roles - #330

Merged
johnwilliams57-nhs merged 1 commit into
developfrom
add-permissions-boundary
Aug 21, 2026
Merged

johnwilliams57-nhs merged 1 commit into
developfrom
add-permissions-boundary

Conversation

@ian-ridehalgh-n

Copy link
Copy Markdown
Contributor

Added a new input variable, permissions_boundary_arn, with a default of null.

Permissions boundary is an optional aws_iam_role arguement which will be treated as unset when null, meaning the change is backward compatible

@ian-ridehalgh-n
ian-ridehalgh-n requested review from a team and matt-mercer as code owners August 21, 2026 09:08
@github-actions

Copy link
Copy Markdown
Contributor

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
627 560 89% 65% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 0851eef by action🐍

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds optional IAM permissions boundaries to every IAM role created by the Terraform module while preserving existing behavior by default.

Changes:

  • Adds the nullable permissions_boundary_arn input.
  • Applies the boundary to all ten IAM roles.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
module/variables.tf Defines the optional boundary ARN input.
module/stepfunctions_send_message.tf Applies it to the send workflow role.
module/stepfunctions_get_messages.tf Applies it to the receive workflow role.
module/lambda_send_message_chunk.tf Applies it to the chunk-sending role.
module/lambda_poll_mailbox.tf Applies it to the mailbox polling role.
module/lambda_fetch_message_chunk.tf Applies it to the chunk-fetching role.
module/lambda_check_send_parameters.tf Applies it to the parameter-checking role.
module/eventbridge_send_message.tf Applies it to the send event role.
module/eventbridge_get_messages.tf Applies it to the receive event role.
module/eventbridge_get_messages_handshake.tf Applies it to the handshake event role.
module/cloudtrail.tf Applies it to the CloudTrail role.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@johnwilliams57-nhs johnwilliams57-nhs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a safe, opt-in addition to support permissions boundaries.
thanks Ian.

@johnwilliams57-nhs
johnwilliams57-nhs merged commit 1749a95 into develop Aug 21, 2026
10 checks passed
@johnwilliams57-nhs
johnwilliams57-nhs deleted the add-permissions-boundary branch August 21, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants