Repository navigation
fix(cloudwatch-metric-alarm): enhance metric alarm module with configurable period - #129
Merged
nhs-oliverslater merged 3 commits intoOct 9, 2026
Merged
Conversation
dave4420
reviewed
Oct 9, 2026
…re' and change default value to 'missing'
nhs-oliverslater
enabled auto-merge (squash)
October 9, 2026 08:55
dave4420
approved these changes
Oct 9, 2026
nhs-oliverslater
deleted the
feature/BCSS-23982-oracle-licence-tracking
branch
October 9, 2026 08:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhance the metric alarm module to allow configuration of the alarm period, defaulting to 60 seconds. Add tests to ensure functionality for both single and multi-dimension alarms.
Context
This change is required to provide flexibility in alarm configurations, allowing users to set custom periods for different metrics, which improves monitoring capabilities.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.