Skip to content

fix(cloudwatch-metric-alarm): enhance metric alarm module with configurable period - #129

Merged
nhs-oliverslater merged 3 commits into
mainfrom
feature/BCSS-23982-oracle-licence-tracking
Oct 9, 2026
Merged

nhs-oliverslater merged 3 commits into
mainfrom
feature/BCSS-23982-oracle-licence-tracking

Conversation

@nhs-oliverslater

Copy link
Copy Markdown
Contributor

Description

Enhance the metric alarm module to allow configuration of the alarm period, defaulting to 60 seconds. Add tests to ensure functionality for both single and multi-dimension alarms.

Context

This change is required to provide flexibility in alarm configurations, allowing users to set custom periods for different metrics, which improves monitoring capabilities.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhs-oliverslater
nhs-oliverslater requested review from a team as code owners October 9, 2026 02:02
Comment thread infrastructure/modules/cloudwatch-metric-alarm/locals.tf Outdated
@nhs-oliverslater
nhs-oliverslater enabled auto-merge (squash) October 9, 2026 08:55
@nhs-oliverslater
nhs-oliverslater merged commit 0d6bb0b into main Oct 9, 2026
17 checks passed
@nhs-oliverslater
nhs-oliverslater deleted the feature/BCSS-23982-oracle-licence-tracking branch October 9, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants