Feature/eli 702 code signing #647
+251
−20
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ module "eligibility_signposting_lambda_function" { | |
| environment = var.environment | ||
| runtime = "python3.13" | ||
| lambda_func_name = "${terraform.workspace == "default" ? "" : "${terraform.workspace}-"}eligibility_signposting_api" | ||
| security_group_ids = [data.aws_security_group.main_sg.id] | ||
| vpc_intra_subnets = [for v in data.aws_subnet.private_subnets : v.id] | ||
| file_name = "../../../dist/lambda.zip" | ||
| handler = "eligibility_signposting_api.app.lambda_handler" | ||
|
|
@@ -33,6 +33,7 @@ module "eligibility_signposting_lambda_function" { | |
| stack_name = local.stack_name | ||
| provisioned_concurrency_count = 5 | ||
| api_domain_name = local.api_domain_name | ||
| environments_with_signing = ["test", "preprod"] | ||
| } | ||
|
Comment on lines
33
to
37
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment. I decided to enforce preprod at the same time as this PR, as the pre-requisite step of deploying the signing infrastructure has already been done |
||
|
|
||
|
|
||
|
|
@@ -69,7 +70,7 @@ resource "aws_lambda_function" "create_secret_lambda" { | |
| variables = { SECRET_NAME = module.secrets_manager.aws_hashing_secret_name } | ||
| } | ||
| vpc_config { | ||
| subnet_ids = [for s in data.aws_subnet.private_subnets : s.id] | ||
| security_group_ids = [data.aws_security_group.main_sg.id] | ||
| } | ||
| } | ||
|
|
@@ -98,7 +99,7 @@ resource "aws_lambda_function" "promote_secret_lambda" { | |
| variables = { SECRET_NAME = module.secrets_manager.aws_hashing_secret_name } | ||
| } | ||
| vpc_config { | ||
| subnet_ids = [for s in data.aws_subnet.private_subnets : s.id] | ||
| security_group_ids = [data.aws_security_group.main_sg.id] | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code_signing_config_arnis conditionally set based onenvironments_with_signing, but the code signing config created by this module usesuntrusted_artifact_on_deployment = "Enforce". With the current stack passingpreprodintoenvironments_with_signing, this will enforce signing in preprod too, which conflicts with the PR description (“sign but do not enforce”). A common approach is to either (a) only attach the config in enforced environments, or (b) make the signing policy configurable per environment (e.g., Warn vs Enforce).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to enforce preprod at the same time as this PR, as the pre-requisite step of deploying the signing infrastructure has already been done