Feature/raa 7531#2790
Open
EdwardWills-nhs wants to merge 5 commits into
Open
Conversation
Bumps [@hapi/content](https://github.com/hapijs/content) from 6.0.0 to 6.0.1. - [Commits](hapijs/content@v6.0.0...v6.0.1) --- updated-dependencies: - dependency-name: "@hapi/content" dependency-version: 6.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
EdwardWills-nhs
requested review from
csaw-nhs,
daniel-mcadam-nhs,
georgeCraftReferrals,
kevinmason-nhs and
petkopetkov2
as code owners
georgeCraftReferrals
previously approved these changes
May 18, 2026
- Split copilot-instructions.md into targeted .instructions.md files (proxy, sandbox, testing, specification) loaded by applyTo patterns - Add /overview, /release, and /add-context prompts - Document release process, sandbox patterns, Actor model, and proxy architecture
There was a problem hiding this comment.
Pull request overview
This PR updates integration test scaffolding for the user-restricted flow, extends the sandbox STU3 cancel-referral response mapping with new request/response examples, bumps various lockfile dependencies, and adds GitHub Copilot prompt/instruction documentation to capture repo workflows and architecture.
Changes:
- Simplifies user-restricted integration test setup by removing
apim-app-flow-varsparameterisation and deleting several negative-path ODS header tests. - Adds additional STU3 cancel-referral mock mappings in the sandbox.
- Adds repository guidance files under
.github/(Copilot context, prompts, and area-specific instruction docs) and updates Python/Node lockfiles.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/test_user_restricted.py | Removes ODS allowlist parametrisation and deletes negative-path ODS header tests, leaving only the 200-path coverage. |
| tests/conftest.py | Removes apim_app_flow_vars fixture and simplifies user_restricted_app creation attributes. |
| sandbox/src/routes/stu3/services/mockResponseProvider.js | Adds new cancel-referral request→response fixture mappings. |
| sandbox/package-lock.json | Updates sandbox Node dependencies/lockfile entries. |
| poetry.lock | Updates Python dependency lockfile entries (e.g., black/requests). |
| .github/prompts/release.prompt.md | Adds a guided prompt for release workflow. |
| .github/prompts/overview.prompt.md | Adds an onboarding/architecture overview prompt. |
| .github/prompts/add-context.prompt.md | Adds a prompt for updating .github/copilot-instructions.md with new verified context. |
| .github/instructions/testing.instructions.md | Adds structured testing conventions and guidance for tests/**. |
| .github/instructions/specification.instructions.md | Adds spec workflow and examples pipeline guidance for specification/**. |
| .github/instructions/sandbox.instructions.md | Adds sandbox architecture/patterns guidance for sandbox/**. |
| .github/instructions/proxy.instructions.md | Adds Apigee proxy architecture and modification guidance for proxies/**. |
| .github/copilot-instructions.md | Adds repo-wide Copilot context (structure, workflows, release). |
Files not reviewed (1)
- sandbox/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
georgeCraftReferrals
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.