Skip to content

fix: group rejection not filtering out invalid records correctly #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgeRobertson wants to merge 1 commit into
base: release_v010
Choose a base branch
from
Open

fix: group rejection not filtering out invalid records correctly #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/dve/core_engine/backends/base/rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,9 @@ def process_node(node: HierarchyNode) -> bool:
for tree in entity_hierarchy.entity_trees.values():
for node in tree.iterate_lowest_descendent_up():
if node.parent_entity and node.mandatory:
entity_issues_found[node.parent_entity] = process_node(node)
result = process_node(node)
if result and not entity_issues_found.get(node.parent_entity):
entity_issues_found[node.parent_entity] = result

return [], entity_issues_found

Expand Down
Loading