Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the per-atom quality report of
validate-assignments, the two protons of a diastereotopic CH2 were relabelled by stripping the last character of the author's label and appendinga/b. Labels that do not end ina/b, such as Mnova'sH-5'ax/H-5'eq, came out mangled, and thepairfield pointed at a label that does not exist.Both rows now keep the label the author gave each shift, and
pairnames the other proton's real label. Ordering is unchanged: the lower shift comes first.labelForAtomand the newrowLabelForAtomshare the per-atom label lookup, so multi-atom rows (H-2, H-6) still split into their per-atom names.Follow-up to #147.
Test plan
npm testinapp/scripts/nmr-cli: 13 of 13 pass, including a new nicotine case whereH-5'a/H-5'bare renamed toH-5'ax/H-5'eqand both the row labels and thepairreferences are checked.