[TASK] Remove thecodingmachine/safe dependency (part 3) - #1616
Merged
Conversation
|
coverage: 74.597% (+2.0%) from 72.604% — SjorsO:drop-dependency-part-3 into MyIntervals:main |
SjorsO
commented
Aug 20, 2026
| } | ||
| return iconv('utf-32le', $this->charset, $utf32EncodedCharacter); | ||
| // The suppression is needed because `\iconv` emits a notice, as well as returning `false`, on failure. | ||
| $convertedCharacter = @\iconv('utf-32le', $this->charset, $utf32EncodedCharacter); |
Contributor
Author
There was a problem hiding this comment.
Suppressing this notice seems like a smart move. We're already handling the error, no reason to emit a notice too
PHPUnit fails if a test emits a notice, so we either have to handle this with a @ or add a small error handling hack in the unit test
oliverklee
requested changes
Aug 20, 2026
oliverklee
left a comment
oliverklee
left a comment
Collaborator
There was a problem hiding this comment.
Great tests! I particularly like the test names, and I also love that we now have tests for the error cases.
I've added a comment on making the tests a bit tighter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All calls in
ParserStatethat can returnfalsenow throw an exception instead, each with its own unit test that checks for the unique exception code.