Open
Conversation
1. Migrates data in worlds/ and groups/ even if the player file doesn't have a matching player in players/ (possible due to legacy versions mixing and matching UUID and username-based file names) 2. Processes players sequentially to avoid resource exhaustion with thousands of files 3. Adds per-profile and per-player exception handling to avoid errors cancelling the whole migration 4. Continues on serialization errors to avoid invalid items skipping the whole inventory
Member
|
Member
|
I will need player data from your end with said issues, so I can test that this pr actually resolved it. You can send here or over discord. I also want you send server logs that shows the errors and resource exhaustion. |
Author
|
Did more testing and cleaned up the changes a bit.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed these changes to get it working on my server from 2014 and 150k+ files