fix(settings): align hotkey columns, widen slider rows, one-line hints - #412
Merged
Conversation
The Settings window reads unevenly at a maximized 2560-wide window: every hotkey editor sits at the far right edge, 1300 px away from the action it binds; slider rows are a bare 180 px track with no scale or unit; the chart-label size slider shows "-1.50" with no hint that it is a pixel delta; two General labels repeat the unit their stepper already shows; General hints run to four-line paragraphs; and the Lines "Global" labels are the only lowercase ones in the window. Reserve a fixed title column and cap the description column on the Hotkeys tab so the editors line up beside the text; extend the shared slider_row with the field's range and formatter, doubling the track and captioning its endpoints; rename the label-size slider to an adjustment in px and format its value with a sign; drop the duplicated units from the idle-close and log-retention labels; show only the first sentence of a multi-sentence hint with the full text in a tooltip; capitalize the Lines "Global" labels. Locale values change in ru/en/es; the tour page is unchanged by the generator. Claude-Session: https://claude.ai/code/session_01HEP2jThagma91nvSCfgsdZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
A live UI audit of the Settings window at a maximized 2560-wide window found six readability defects:
-1.50with nothing saying it is a pixel delta.Fixes, all inside
settings/**and the three locale files (ru/en/es):slider_rowtakes the field's range and a formatter: a wider track, min/max captions under it, and a right-aligned value with its unit (85%,1.0 px).-1.5 px).…and the full text in a tooltip; the locale strings are unchanged.locales/README.md.One static contract (
theme_contract::analytics) pinned the oldhint(&t!(...))call shape and was updated to the new one; it still asserts the valuation hint key is rendered.How to verify
cargo test --workspace(thetheme_contracttarget covers the updated pin).https://claude.ai/code/session_01HEP2jThagma91nvSCfgsdZ