Repository navigation
Keys mode never types; staged commands pause it; Alt+Shift+F1 key help - #205
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In keys mode (Alt+Shift+H) a key no longer reaches the command input:
handleKeydowninsrc/gmcp/Client/Keystrokes.tslet an unbound key type, and once the input had text every typing key typed (acdc46f). Now a key press with a one-characterkeyand no Ctrl, Alt or Meta is always stopped in keys mode; it runs its binding if it has one.autosendfalse (Yahtzee's Shift+S,score) fills the input and turns keys mode off ("Keys mode off") so the player can type the rest. Sending it turns keys mode back on ("Keys mode on"). Cleared if the last modal layer leaves or the player toggles keys mode.src/reservedShortcuts.ts.docs/keystrokes.mdsays all this, and that Mudlet always types a plain Space (Mudlet'sTCommandLine.cppnever offers it to key bindings) and keeps a plain Escape.Tried in Chrome against the live MOO as a guest, with the Yahtzee layer injected into the client and keys sent through the browser extension:
x,sand Space left the input empty andssentsheet; Shift+S then "chance" sentscore chanceand keys mode came back on; Alt+Shift+F1 reached the page and key help spoke as above. Not tried: NVDA, or Alt+Shift+F1 pressed at the OS level.Not handled: IME composition still types in keys mode (the handler returns early on
isComposing).The Mudlet package side is MongooseMoo/mudlet-package, branch
fix/keys-mode-never-types.