Skip to content

Keys mode never types; staged commands pause it; Alt+Shift+F1 key help - #205

Merged
ctoth merged 2 commits into
masterfrom
fix/keys-mode-never-types
Oct 24, 2026
Merged

ctoth merged 2 commits into
masterfrom
fix/keys-mode-never-types

Conversation

@ctoth

@ctoth ctoth commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

In keys mode (Alt+Shift+H) a key no longer reaches the command input:

  • Before, handleKeydown in src/gmcp/Client/Keystrokes.ts let an unbound key type, and once the input had text every typing key typed (acdc46f). Now a key press with a one-character key and no Ctrl, Alt or Meta is always stopped in keys mode; it runs its binding if it has one.
  • A binding with autosend false (Yahtzee's Shift+S, score ) fills the input and turns keys mode off ("Keys mode off") so the player can type the rest. Sending it turns keys mode back on ("Keys mode on"). Cleared if the last modal layer leaves or the player toggles keys mode.
  • Alt+Shift+F1 is key help, like NVDA's input help: each key says what it does ("S: Scorecards", "X: not bound", or the client's reason for a key it keeps) and does nothing else. Escape or Alt+Shift+F1 ends it. Reserved in src/reservedShortcuts.ts.
  • docs/keystrokes.md says all this, and that Mudlet always types a plain Space (Mudlet's TCommandLine.cpp never offers it to key bindings) and keeps a plain Escape.

Tried in Chrome against the live MOO as a guest, with the Yahtzee layer injected into the client and keys sent through the browser extension: x, s and Space left the input empty and s sent sheet; Shift+S then "chance" sent score chance and keys mode came back on; Alt+Shift+F1 reached the page and key help spoke as above. Not tried: NVDA, or Alt+Shift+F1 pressed at the OS level.

Not handled: IME composition still types in keys mode (the handler returns early on isComposing).

The Mudlet package side is MongooseMoo/mudlet-package, branch fix/keys-mode-never-types.

@ctoth
ctoth merged commit 9fa5845 into master Oct 24, 2026
2 checks passed
@ctoth
ctoth deleted the fix/keys-mode-never-types branch October 24, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant