Repository navigation
Fix MOO assignments inside conditions and expressions - #204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize local assignment targets throughout masked MOO source, including immediately after expression punctuation and across line breaks. This fixes the false undefined-local warning for
if (valid(channel = this:current_channel(player))); property names remain excluded from local definitions. ToastStunt src/parser.y:139 and :466-486 establish the syntax, and the installed tree-sitter parser already parses the example successfully. No npm parser release is needed for this fix. Validation: the normal commit hook ran typecheck and staged lint; hosted PR CI is pending.