Skip to content

fix: generate metadata error handling to fix deleted feeds caching problem #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alessandro100 merged 1 commit into from
Oct 6, 2026
Merged

fix: generate metadata error handling to fix deleted feeds caching problem #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/app/[locale]/feeds/[feedDataType]/[feedId]/static/map/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,23 @@ export async function generateMetadata(
): Promise<Metadata> {
const { feedId, feedDataType } = await params;

const [t, feedData] = await Promise.all([
getTranslations(),
fetchGuestFeedData(feedDataType, feedId),
]);
try {
const [t, feedData] = await Promise.all([
getTranslations(),
fetchGuestFeedData(feedDataType, feedId),
]);

return generateMapFeedMetadata({
feed: feedData.feed,
t,
});
return generateMapFeedMetadata({
feed: feedData.feed,
t,
});
} catch (e) {
console.error(
`[StaticFullMapViewPage] generateMetadata failed to fetch feed ${feedId}:`,
e,
);
return {};
}
}

/**
Expand Down
18 changes: 14 additions & 4 deletions src/app/[locale]/feeds/[feedDataType]/[feedId]/static/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,20 @@ export async function generateMetadata(
): Promise<Metadata> {
const { feedId, feedDataType } = await params;

const [t, feedData] = await Promise.all([
getTranslations(),
fetchGuestFeedData(feedDataType, feedId),
]);
let t: Awaited<ReturnType<typeof getTranslations>>;
let feedData: FeedDataResult;
try {
[t, feedData] = await Promise.all([
getTranslations(),
fetchGuestFeedData(feedDataType, feedId),
]);
} catch (e) {
console.error(
`[StaticFeedPage] generateMetadata failed to fetch feed ${feedId}:`,
e,
);
notFound();
}

return generateFeedMetadata({
feed: feedData.feed,
Expand Down
Loading