Fix: prod deploy workflow uses infra release tag as JAR version#5
Merged
Conversation
|
|
davidgamez
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a release is published on this repo, the release trigger passes github.event.release.tag_name (e.g. v1.0.0) as the GBFS_API_IMAGE_VERSION. The deployer then uses that value as the Maven artifact version, causing the build to fail because no such version exists in Maven Central:
Could not find artifact org.mobilitydata:gbfs-validator-java-api:jar:v1.0.0 in central
Root cause
The infra repo now has its own versioning (v1.0.0) that is decoupled from the gbfs-validator-java JAR version.
Fix
Remove github.event.release.tag_name from GBFS_API_IMAGE_VERSION. When triggered by a release event (or a workflow_dispatch with no version specified), the field is now empty and the deployer correctly falls back to RELEASE, downloading the latest release from Maven Central.