Conversation
Author
|
Closing this PR because Issue #258 explicitly asks contributors to obtain maintainer permission before starting an implementation, and no approval comment is present. The issue remains open for a policy-compliant contribution after maintainer confirmation; no code was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-colorsetting in the interactive request status barWhy
Issue #258 reports that
mmx quota show --no-colorremoves ANSI styling from the quota table but leaves the request status bar colored.maybeShowStatusBar()assembled ANSI sequences unconditionally, even though the CLI already exposedconfig.noColorfor the same command.What changed
The status bar now routes each styled fragment through a small local helper. With
config.noColorenabled it emits the same text without escape sequences; normal TTY output keeps the existing styling and layout.Validation
bun test test/output/status-bar.test.ts— 2 passedbun run typecheck— passedbun run lint— no errors; one pre-existing warning intest/sdk/speech.test.tsgit diff --check— passedFull
bun testwas also run. The existing Windows/runner-dependent suite has 12 unrelated failures involving proxy/network guidance, agent file permissions, and a download writer-error simulation; the new status-bar tests pass.Fixes #258
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.