Skip to content

fix(output): honor no-color in status bar - #269

Closed
dvd233 wants to merge 1 commit into
MiniMax-AI:mainfrom
dvd233:fix/no-color-status-bar-258
Closed

dvd233 wants to merge 1 commit into
MiniMax-AI:mainfrom
dvd233:fix/no-color-status-bar-258

Conversation

@dvd233

@dvd233 dvd233 commented Sep 23, 2026

Copy link
Copy Markdown

Summary

  • honor the existing --no-color setting in the interactive request status bar
  • keep the status bar's text and credential masking unchanged when colors are disabled
  • add regression coverage for colored and uncolored TTY output

Why

Issue #258 reports that mmx quota show --no-color removes ANSI styling from the quota table but leaves the request status bar colored. maybeShowStatusBar() assembled ANSI sequences unconditionally, even though the CLI already exposed config.noColor for the same command.

What changed

The status bar now routes each styled fragment through a small local helper. With config.noColor enabled it emits the same text without escape sequences; normal TTY output keeps the existing styling and layout.

Validation

  • bun test test/output/status-bar.test.ts — 2 passed
  • bun run typecheck — passed
  • bun run lint — no errors; one pre-existing warning in test/sdk/speech.test.ts
  • git diff --check — passed

Full bun test was also run. The existing Windows/runner-dependent suite has 12 unrelated failures involving proxy/network guidance, agent file permissions, and a download writer-error simulation; the new status-bar tests pass.

Fixes #258


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@dvd233

dvd233 commented Sep 23, 2026

Copy link
Copy Markdown
Author

Closing this PR because Issue #258 explicitly asks contributors to obtain maintainer permission before starting an implementation, and no approval comment is present. The issue remains open for a policy-compliant contribution after maintainer confirmation; no code was merged.

@dvd233 dvd233 closed this Sep 23, 2026
@dvd233
dvd233 deleted the fix/no-color-status-bar-258 branch September 23, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] --no-color 未去除请求状态栏的 ANSI 颜色

1 participant