Repository navigation
Observe lease release before expiry worker restart - #585
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment Worker restart tests could start the next Worker before PostgreSQL had released the previous backend's advisory lease, failing startup with
ErrLeaseHeld. Both restart fixtures now use the existing lease-release observer before starting the next Worker. Production behavior and all expiry/deadline assertions remain unchanged.Validation: both restart scenarios passed 50 repetitions under the race detector; all 128 tests selected by affected integration shard 2/3 passed (151.789s) against a dedicated PostgreSQL database with the pinned official SDK; full six-line diff review and whitespace checks passed. The original CI failure is recorded in #583; the baseline did not reproduce locally during 50 race repetitions.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.