Repository navigation
Declare Runtime observation states once - #580
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime observation modes, statuses, lifecycle states, instance kinds and allocation diagnostics were duplicated across Go tags, constants and generated clients. Give each closed set one typed Go definition and generate the client projections from it; update producers, validators and persistence boundaries to use those types. Remove the old runtimeobs definitions, diagnostic map and duplicate administration detail constants.
Wire values, required fields, nullability and errors are unchanged, including open Provider observation reasons. All existing test assertions are preserved after type and import changes.
Validation: coordinator full diff review; 3,252 changed-package and direct-dependent cases passed with seven documented platform/fixture/helper skips, plus 10 database integration cases with no skips. Client 465 and Web 52 tests, both typechecks, module build/vet, OpenAPI freshness and generator checks passed. Dereferenced management and machine schemas are semantically identical; the public schema is byte-identical.
The microsandbox helper module records the existing pinned indirect dependencies required by the shared type owner. Its full Makefile checks, standalone readonly build and tidy freshness also pass.