Repository navigation
Accept declared Runtime observation reasons - #571
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Provider can declare
Observeunsupported with a valid authored reason such asnative_metrics_not_supported. Core already preserves that result, but the management schema and client rejected it, and Web assumed every reason had a translation.Accept the Provider contract’s safe reason codes in both observation schemas and the client’s managed-unsupported branch. Preserve existing identity, null-sample and status/reason rules; unknown safe codes display directly in Web while known reasons retain their translations. Remove the obsolete generated reason enums and update the owning English/Chinese protocol documentation.
Validation: shared Go/service/HTTP/schema/client fixtures cover valid and malformed codes, length bounds and trailing newlines; actual Go classifications are checked against the client’s existing unavailable-reason set. Independent blind review and coordinator full-diff review passed. The only schema changes are the two management observation reason properties; the pinned public contract is unchanged.
Checks: module build/vet; 2,391 passing Go tests/subtests with three explicit platform/helper gates; 766 client tests; 381 Web tests and two English/Chinese component regressions; client/Web typechecks; OpenAPI generation/drift, documentation and naming checks; website build and 22 site tests.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.