Skip to content

Accept declared Runtime observation reasons - #571

Merged
SaladDay merged 1 commit into
aos/cutoverfrom
aos/declared-observation-reasons
Oct 8, 2026
Merged

SaladDay merged 1 commit into
aos/cutoverfrom
aos/declared-observation-reasons

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

A Provider can declare Observe unsupported with a valid authored reason such as native_metrics_not_supported. Core already preserves that result, but the management schema and client rejected it, and Web assumed every reason had a translation.

Accept the Provider contract’s safe reason codes in both observation schemas and the client’s managed-unsupported branch. Preserve existing identity, null-sample and status/reason rules; unknown safe codes display directly in Web while known reasons retain their translations. Remove the obsolete generated reason enums and update the owning English/Chinese protocol documentation.

Validation: shared Go/service/HTTP/schema/client fixtures cover valid and malformed codes, length bounds and trailing newlines; actual Go classifications are checked against the client’s existing unavailable-reason set. Independent blind review and coordinator full-diff review passed. The only schema changes are the two management observation reason properties; the pinned public contract is unchanged.

Checks: module build/vet; 2,391 passing Go tests/subtests with three explicit platform/helper gates; 766 client tests; 381 Web tests and two English/Chinese component regressions; client/Web typechecks; OpenAPI generation/drift, documentation and naming checks; website build and 22 site tests.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@SaladDay
SaladDay merged commit e8f5ccd into aos/cutover Oct 8, 2026
24 checks passed
@SaladDay
SaladDay deleted the aos/declared-observation-reasons branch October 8, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant