Repository navigation
Remove runtime composition wrappers - #565
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
aos/remove-runtime-composition-wrappers
branch
from
October 8, 2026 12:47
2259871 to
da91427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core startup currently reaches gateway construction and connection observation through forwarding wrappers. Compose the gateway in the server, let its registry close upgraded connections, and let
runtimeenrollment.Connectionsown the existing observation operation and HTTP handler. Delete the runtime wrapper package and server connection adapter; share one gateway fixture across the three integration callers.Routes, authentication rechecks, HTTP responses and shutdown order are unchanged. The deleted gateway constructor’s nil-dependency error branch has no applicable current caller. Production code decreases by 39 lines.
Validation: coordinator full-diff review and normalized function-body comparison; module build/vet; 327 unit/direct-dependent tests and 162 focused integration tests, with zero skips; OpenAPI, naming and documentation checks. No protocol or generated-schema changes.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.