Repository navigation
Use i18next for sandbox translations - #559
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandbox label and diagnostic formatters now use the existing i18next namespaces and supported language type. Move their resources into i18n, delete the parallel translation helper and unused node-status formatter, and preserve all English/Chinese copy, interpolation and explicit language behavior.
Validation: Web typecheck; 25 affected unit-test files (124 tests); exhaustive temporary sandbox/firstRun lookup and interpolation comparison in both languages plus localization tests (31 tests); naming guard. Coordinator reviewed the complete diff.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.