Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
async_modeparameter to theasyncModefield consumed byVideoAPI.generate_videoandimage_to_video.node:testregression and expose it throughpnpm run test.Why
The REST tool schema advertises
async_mode, butVideoAPIchecksasyncMode. Before this change, a REST request withasync_mode: trueentered the blocking polling/download path instead of returning the submitted task ID. The service could then describe an already completed result as a newly submitted task.Verification
pnpm run buildpnpm run test(1 passed; the baseline test fails before the patch because polling starts)git diff --checkThe repository-wide
pnpm run lintstill reports the pre-existing formatting failure in all 20 source files; this focused change does not rewrite unrelated formatting.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.