Conversation
Signed-off-by: dvd233 <111864431+dvd233@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fall back to the cloned
voice_idwhen a cloned voice response does not includevoice_name, while preserving the legacy display name when it is present.Why
The current MiniMax Voice Management API response for
voice_cloningentries providesvoice_id,description, andcreated_time, but notvoice_name. The existing formatter interpolated the missing field asName: undefined, making cloned voices harder to identify in MCP clients.Reference: https://platform.minimax.io/docs/api-reference/voice-management-get
Verification
pnpm run buildvoice_cloningresponse shapesgit diff --checkThe repository-wide
pnpm run lintcurrently fails on the unchanged baseline formatting in all 20 source files; no formatting-only changes are included in this focused patch.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.