Fix variant suffix resolution and binary target name in makefile - #33
Open
tobfal wants to merge 1 commit into
Open
Fix variant suffix resolution and binary target name in makefile#33tobfal wants to merge 1 commit into
tobfal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ifeq (LARGE_BIOMES, 1)compares the literal string against "1", so it never matches and BIN_SUFFIX is always "sb" regardless of the options.The Windows target is named
main.exewhile the recipe writes to$@-$(BIN_SUFFIX). Target and output never match, so make rebuilds everything on every invocation, and if a file named main.exe happens to exist it reports "Nothing to be done" and skips the build entirely.Changes
existing main-sb* / main-lb* gitignore patterns cover all four variants
-o $@Verified on Windows