Skip to content

Notebot: replace out of range note rounding with transposing #6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rewrite wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −5
Open

Notebot: replace out of range note rounding with transposing #6668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/meteordevelopment/meteorclient/systems/modules/misc/Notebot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ public class Notebot extends Module {
.build()
);

public final Setting<Boolean> roundOutOfRange = sgGeneral.add(new BoolSetting.Builder()
.name("round-out-of-range")
.description("Rounds out of range notes")
public final Setting<Boolean> transposeOutOfRange = sgGeneral.add(new BoolSetting.Builder()
.name("transpose-out-of-range")
.description("Transposes out of range notes")
.defaultValue(false)
.build()
);
Expand Down
10 changes: 8 additions & 2 deletions src/main/java/meteordevelopment/meteorclient/utils/notebot/decoder/SongDecoders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,14 @@ private static void fixSong(Song song) {

int n = note.getNoteLevel();
if (n < 0 || n > 24) {
if (notebot.roundOutOfRange.get()) {
note.setNoteLevel(n < 0 ? 0 : 24);
if (notebot.transposeOutOfRange.get()) {
while (n < 0) {
n += 12;
}
while (n > 24) {
n -= 12;
}
note.setNoteLevel(n);
} else {
notebot.warning("Note at tick %d out of range.", tick);
iterator.remove();
Expand Down
Loading